-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap tests in pester blocks #12700
Wrap tests in pester blocks #12700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor comment.
@xtqqczze Thanks! This helps us to move to Pester 5.0.
test/powershell/Language/Classes/scripting.Classes.NestedModules.tests.ps1
Show resolved
Hide resolved
@iSazonov this was WIP, but I ran into some issues with multiple |
@xtqqczze If you are going to prepare all test to being Pester v5 compatible it makes sense to open a meta issue where list all test files and their status. |
Hello @iSazonov! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
meta issue opened for wider pester v5 disussion #12816 |
🎉 Handy links: |
PR Summary
Wrap tests in pester blocks to prepare for pesterv5
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.