Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap tests in pester blocks #12700

Merged
1 commit merged into from
May 23, 2020
Merged

Wrap tests in pester blocks #12700

1 commit merged into from
May 23, 2020

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented May 16, 2020

PR Summary

Wrap tests in pester blocks to prepare for pesterv5

PR Context

PR Checklist

@ghost ghost assigned daxian-dbw May 16, 2020
WIP
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment.

@xtqqczze Thanks! This helps us to move to Pester 5.0.

@iSazonov iSazonov added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label May 19, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.4 milestone May 19, 2020
@xtqqczze xtqqczze marked this pull request as ready for review May 22, 2020 14:18
@xtqqczze
Copy link
Contributor Author

@iSazonov this was WIP, but I ran into some issues with multiple Describe blocks, so I will not add any more commits. This PR is ready to merge.

@iSazonov
Copy link
Collaborator

@xtqqczze If you are going to prepare all test to being Pester v5 compatible it makes sense to open a meta issue where list all test files and their status.

@iSazonov iSazonov added the AutoMerge informs the bot to automerge the PR label May 23, 2020
@ghost
Copy link

ghost commented May 23, 2020

Hello @iSazonov!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 1f252f8 into PowerShell:master May 23, 2020
@xtqqczze xtqqczze deleted the convert-pester5 branch May 23, 2020 15:32
@xtqqczze
Copy link
Contributor Author

meta issue opened for wider pester v5 disussion #12816

@ghost
Copy link

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge informs the bot to automerge the PR CL-Test Indicates that a PR should be marked as a test change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants