Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action for PR creation and Wix file generation logic #12748

Merged
merged 6 commits into from
May 22, 2020

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented May 21, 2020

PR Summary

When we update to a new version of .NET we need to update the files.wxs file as well. This change automates that. The script needs to be run on Windows for that though.

Also add GitHub Action to create PR when there is an update, scheduled for 13:00 UTC. (6 AM PST now)

PR Context

PR Checklist

@adityapatwardhan adityapatwardhan marked this pull request as draft May 21, 2020 22:49
@adityapatwardhan adityapatwardhan marked this pull request as ready for review May 22, 2020 01:05
@adityapatwardhan adityapatwardhan changed the title Add logic to create the Wix packaging file when updating .NET previews Add GitHub action for PR creation and Wix file generation logic May 22, 2020
@adityapatwardhan
Copy link
Member Author

@PoshChan Please remind me in 1 hour

@adityapatwardhan adityapatwardhan merged commit 0e435a5 into PowerShell:master May 22, 2020
@adityapatwardhan adityapatwardhan deleted the AutoUpdateDotnet branch May 22, 2020 01:47
@PoshChan
Copy link
Collaborator

@adityapatwardhan, this is the reminder you requested 1 hour ago

@bergmeister
Copy link
Contributor

bergmeister commented May 22, 2020

@adityapatwardhan This seems to create a PR for each fork and is going to create a lot of noise, is it possible to be opt-in or apply only to the PowerShell organisation itself?
bergmeister#4
The discussion here suggests to add an if conditional on the job: if: github.repository == 'PowerShell/PowerShell'
I tried to create a PR here: #12763

@adityapatwardhan
Copy link
Member Author

@bergmeister Thank you for finding this and creating a PR for the fix.

@adityapatwardhan adityapatwardhan added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label May 22, 2020
@adityapatwardhan adityapatwardhan added this to the 7.1.0-preview.4 milestone May 22, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Tools Indicates that a PR should be marked as a tools change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants