New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: Use coalesce expression #12829
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCS1128
ghost
assigned iSazonov
May 28, 2020
iSazonov
reviewed
May 29, 2020
iSazonov
added
the
CL-CodeCleanup
Indicates that a PR should be marked as a Code Cleanup change in the Change Log
label
May 29, 2020
Co-authored-by: Ilya <darpa@yandex.ru>
iSazonov
approved these changes
May 29, 2020
TravisEz13
reviewed
May 29, 2020
TravisEz13
reviewed
May 29, 2020
TravisEz13
requested changes
May 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments in wldpNativeMethods
ghost
added
the
Waiting on Author
The PR was reviewed and requires changes or comments from the author before being accept
label
May 29, 2020
ghost
removed this from the 7.1.0-preview.4 milestone
May 29, 2020
@iSazonov Please don't put the milestone until PRs are merged. |
ghost
removed
the
Waiting on Author
The PR was reviewed and requires changes or comments from the author before being accept
label
May 29, 2020
TravisEz13
approved these changes
May 29, 2020
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CL-CodeCleanup
Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Automate fix of RCS1128
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.