New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Get-ChildItem -Recurse -Name #12834
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
added
the
CL-Performance
Indicates that a PR should be marked as a performance improvement in the Change Log
label
May 29, 2020
ghost
assigned daxian-dbw
May 29, 2020
PoshChan
reviewed
May 29, 2020
iSazonov
force-pushed
the
filesystemprovider-getnames
branch
from
June 1, 2020 08:45
293d359
to
6c461d5
Compare
PoshChan
reviewed
Jun 1, 2020
PoshChan
reviewed
Jun 1, 2020
PoshChan
reviewed
Jun 2, 2020
PoshChan
reviewed
Jun 2, 2020
PoshChan
reviewed
Jun 2, 2020
PoshChan
reviewed
Jun 2, 2020
PoshChan
reviewed
Jun 2, 2020
PoshChan
reviewed
Jun 2, 2020
PoshChan
reviewed
Jun 2, 2020
PoshChan
reviewed
Jun 2, 2020
PoshChan
reviewed
Jun 2, 2020
PoshChan
reviewed
Jun 2, 2020
PoshChan
reviewed
Jun 2, 2020
PoshChan
reviewed
Jun 2, 2020
PoshChan
reviewed
Jun 2, 2020
iSazonov
force-pushed
the
filesystemprovider-getnames
branch
from
June 2, 2020 13:41
5b8fae2
to
d9673b0
Compare
PoshChan
reviewed
Jun 2, 2020
PoshChan
reviewed
Jun 2, 2020
PoshChan
reviewed
Jun 3, 2020
PoshChan
reviewed
Jun 3, 2020
PoshChan
reviewed
Jun 3, 2020
PoshChan
reviewed
Jun 3, 2020
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
iSazonov
force-pushed
the
filesystemprovider-getnames
branch
from
December 28, 2020 05:46
5ff026a
to
149b003
Compare
iSazonov
force-pushed
the
filesystemprovider-getnames
branch
from
April 23, 2021 12:09
3ed70f0
to
14a71e9
Compare
22 tasks
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CL-Performance
Indicates that a PR should be marked as a performance improvement in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Addresses #9119
Intention is to improve performance without changing current behavior. Later we can more easily fix already known bugs/inconsistencies and add new features.
Performance win is up to 50%.
Allocations are dramatically reduces if filtering is used (now no allocations are for discarded paths).
Today the .Net API does not support:
Depth
(tracking issue) and we use a workaround in the case.PR Context
Current implementation is a generic (common for all providers) enumerating code which is very expensive. New implementation uses new .Net API for file enumerating. The API is very fast and efficient, especially if filtering is used.
The follow intention is to use this approach later for
dir -recurse
too and then fix known bugs and add new features.PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.