Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable NonPrivateReadonlyFieldsMustBeginWithUpperCaseLetter #12855

Conversation

xtqqczze
Copy link
Contributor

PR Summary

Disable StyleCop rule NonPrivateReadonlyFieldsMustBeginWithUpperCaseLetter which conflicts with the PowerShell written naming convention.

PR Context

#12819

PR Checklist

@ghost ghost added the Review - Needed The PR is being reviewed label Jun 10, 2020
@ghost
Copy link

ghost commented Jun 10, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan adityapatwardhan merged commit 22aaf9f into PowerShell:master Jun 12, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 12, 2020
@xtqqczze xtqqczze deleted the disable-NonPrivateReadonlyFieldsMustBeginWithUpperCaseLetter branch June 13, 2020 09:10
@adityapatwardhan adityapatwardhan added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jun 24, 2020
@adityapatwardhan adityapatwardhan added this to the 7.1.0-preview.4 milestone Jun 24, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Tools Indicates that a PR should be marked as a tools change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants