Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the upload of ETW traces to CLR CAP in Windows daily build #12890

Merged
merged 3 commits into from
Jun 8, 2020

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jun 3, 2020

PR Summary

A variable group was created that contains the variable CapIngressToken, which stores the ingress token used for the upload.
Update the windows-daily.yml file to provide the ingress token when calling Stop-TraceCollection, so the upload can happen.

Here is the build that validated the changes in this PR:
https://dev.azure.com/powershell/PowerShell/_build/results?buildId=54570&view=results

PR Checklist

@daxian-dbw daxian-dbw marked this pull request as draft June 4, 2020 06:16
@daxian-dbw
Copy link
Member Author

Make this PR a draft because there seems to be an issue in uploading the trace to //CLRCAP.

@TravisEz13 TravisEz13 closed this Jun 4, 2020
@TravisEz13 TravisEz13 reopened this Jun 4, 2020
@daxian-dbw daxian-dbw marked this pull request as ready for review June 5, 2020 00:07
@daxian-dbw
Copy link
Member Author

@PoshChan Please retry static

@PoshChan
Copy link
Collaborator

PoshChan commented Jun 5, 2020

@daxian-dbw, successfully started retry of PowerShell-CI-static-analysis

@daxian-dbw
Copy link
Member Author

daxian-dbw commented Jun 5, 2020

Contacted the CAP team and it turns out the trace files were uploaded correctly from my test runs of Windows-daily build (see below telemetry from the CAP side).
So the changes to windows-daily.yml is good to go.

image

@adityapatwardhan adityapatwardhan merged commit 1656f51 into master Jun 8, 2020
@daxian-dbw daxian-dbw deleted the cap-upload branch June 8, 2020 20:25
@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jun 19, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.4 milestone Jun 19, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Tools Indicates that a PR should be marked as a tools change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants