Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct isError parameter with Write-Log #12989

Merged
merged 3 commits into from
Jun 18, 2020

Conversation

TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Jun 18, 2020

PR Summary

It looks like the wrong parameter was being used with Write-Log causing difficulties when logging errors.

PR Context

Created from #11592

PR Checklist

@TravisEz13
Copy link
Member Author

created from #11592

build.psm1 Outdated Show resolved Hide resolved
@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jun 18, 2020
build.psm1 Outdated Show resolved Hide resolved
build.psm1 Outdated Show resolved Hide resolved
build.psm1 Outdated Show resolved Hide resolved
@TravisEz13 TravisEz13 changed the title Use correct isError parameter with Write-Log when logging an error Use correct isError parameter with Write-Log Jun 18, 2020
@TravisEz13 TravisEz13 merged commit ac2b1cf into PowerShell:master Jun 18, 2020
@TravisEz13 TravisEz13 deleted the WriteLogFix001 branch June 18, 2020 18:48
@iSazonov iSazonov added this to the 7.1.0-preview.4 milestone Jun 19, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Tools Indicates that a PR should be marked as a tools change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants