Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component ref when regenerating the WIX file #13019

Merged

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Jun 23, 2020

PR Summary

When the Wix file is to be regenerated, the script was iterating through the components instead of the compenent refs. Fixed the the collection to iterate over.

PR Context

PR Checklist

@ghost ghost assigned daxian-dbw Jun 23, 2020
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jun 23, 2020
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must take you guys some time to root cause this :)

@adityapatwardhan adityapatwardhan merged commit a9206d5 into PowerShell:master Jun 23, 2020
@adityapatwardhan adityapatwardhan deleted the FixWixScriptBug branch June 23, 2020 23:43
@adityapatwardhan
Copy link
Member Author

Its all thanks to @TravisEz13

@ghost
Copy link

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants