Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix IDE0005: Remove unnecessary usings #13504

Closed
wants to merge 1 commit into from

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Aug 22, 2020

@ghost ghost assigned rjmholt Aug 22, 2020
@iSazonov iSazonov self-requested a review August 24, 2020 19:00
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 28, 2020
@ghost ghost added the Stale label Sep 12, 2020
@ghost
Copy link

ghost commented Sep 12, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@rjmholt rjmholt added the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 14, 2020
@ghost ghost closed this Sep 24, 2020
@iSazonov iSazonov reopened this Sep 24, 2020
@anmenaga anmenaga removed the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 29, 2020
@anmenaga
Copy link
Contributor

Maintainers think this is a low risk change, considering that a build break will detect any error in this change;
however conflict must be fixed and CI have to be passing; please put back "Review - Maintainer" label once this is updated.

@ghost ghost removed the Stale label Sep 29, 2020
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Oct 13, 2020
@ghost ghost added the Stale label Oct 31, 2020
@ghost
Copy link

ghost commented Oct 31, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@iSazonov
Copy link
Collaborator

iSazonov commented Nov 5, 2020

@xtqqczze Please split the PR by project/folder.

@ghost ghost removed the Stale label Nov 5, 2020
@xtqqczze xtqqczze changed the title Remove unused usings WIP: Fix IDE0005: Remove unused usings Nov 9, 2020
@xtqqczze xtqqczze changed the title WIP: Fix IDE0005: Remove unused usings WIP: Fix IDE0005: Remove unnecessary import Nov 9, 2020
@xtqqczze xtqqczze changed the title WIP: Fix IDE0005: Remove unnecessary import WIP: Fix IDE0005: Remove unnecessary usings Nov 10, 2020
@iSazonov
Copy link
Collaborator

@xtqqczze Can we close?

@xtqqczze
Copy link
Contributor Author

@iSazonov We still have System.Management.Automation 🙁

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Nov 22, 2020
@ghost
Copy link

ghost commented Dec 10, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost added the Stale label Dec 10, 2020
@ghost ghost closed this Dec 21, 2020
@iSazonov iSazonov reopened this Dec 21, 2020
@ghost ghost closed this Dec 31, 2020
@stan-sz
Copy link

stan-sz commented Nov 30, 2022

Turning this code analysis rule to a warning/error mode helps maintain leaner code base and open up path to removed unused Project/PackageReferences from projects. Just

Based on dotnet/roslyn#41640 (comment) this property is already enabled for this repo:

<GenerateDocumentationFile>true</GenerateDocumentationFile>

@ghost ghost removed the Stale label Nov 30, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants