WIP: Enable CA1507: Use nameof to express symbol names #13875
Conversation
src/Microsoft.Management.UI.Internal/HelpWindow/HelpViewModel.cs
Outdated
Show resolved
Hide resolved
xtqqczze
requested review from
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
| @@ -185,7 +185,7 @@ private bool FilterMatch(ManagementObject obj) | |||
| foreach (string desc in Description) | |||
| { | |||
| WildcardPattern wildcardpattern = WildcardPattern.Get(desc, WildcardOptions.IgnoreCase); | |||
| if (wildcardpattern.IsMatch((string)obj["Description"])) | |||
| if (wildcardpattern.IsMatch((string)obj[nameof(Description)])) | |||
There was a problem hiding this comment.
Here Description is a property name of ManagementObject.
Or can it be:
| if (wildcardpattern.IsMatch((string)obj[nameof(Description)])) | |
| if (wildcardpattern.IsMatch((string)obj[nameof(obj.Description)])) |
Also what about "InstalledBy" in the file?
I suggest to revert such non-obvious changes here and below because we can break something tricky.
| @@ -89,55 +89,55 @@ internal bool HasHostWindow | |||
| { | |||
| get | |||
| { | |||
| return (bool)_graphicalHostReflectionWrapper.GetPropertyValue("HasHostWindow"); | |||
| return (bool)_graphicalHostReflectionWrapper.GetPropertyValue(nameof(HasHostWindow)); | |||
There was a problem hiding this comment.
The same. HasHostWindow is a property of GraphicalHostReflectionWrapper.
I see the same patterns below.
| RemotingEncoder.AddNoteProperty<object>(dest, "TargetObject", delegate () { return TargetObject; }); | ||
| RemotingEncoder.AddNoteProperty<string>(dest, "FullyQualifiedErrorId", delegate () { return FullyQualifiedErrorId; }); | ||
| RemotingEncoder.AddNoteProperty<InvocationInfo>(dest, "InvocationInfo", delegate () { return InvocationInfo; }); | ||
| RemotingEncoder.AddNoteProperty<Exception>(dest, nameof(Exception), delegate () { return Exception; }); |
There was a problem hiding this comment.
Again, is the reference to Exception right?
Below in the file too.
| informationRecord.ProcessId = RemotingDecoder.GetPropertyValue<uint>(inputObject, "ProcessId"); | ||
| informationRecord.NativeThreadId = RemotingDecoder.GetPropertyValue<uint>(inputObject, "NativeThreadId"); | ||
| informationRecord.ManagedThreadId = RemotingDecoder.GetPropertyValue<uint>(inputObject, "ManagedThreadId"); | ||
| informationRecord.User = RemotingDecoder.GetPropertyValue<string>(inputObject, nameof(User)); |
xtqqczze
changed the title
|
@xtqqczze Please address my comments. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
ghost
added
the
Waiting on Author
|
@xtqqczze Can we continue? If there are doubts please revert and suppress locally. |
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment. |
ghost
closed this
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1507
Follow-up #12716