Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Enable adding strongly typed format view defintion with Update-FormatData #14286

Closed
wants to merge 7 commits into from

Conversation

Jawz84
Copy link
Contributor

@Jawz84 Jawz84 commented Nov 29, 2020

PR Summary

Closes #7845

The Update-TypeData command offers flexibility to load type data at runtime not only through loading files, but also through providing strongly typed type data. This Pull Request aims to bring that same kind of functionality to Update-FormatData.

  • Add a parameterset for adding strongly typed format view definitions to the current session. (-TypeName and -FormatViewDefinition parameters)
  • Add a test for this.
  • Add a parameterset for dynamically adding format view definitions (-TypeName, -ListProperties, - TableProperties, -WideProperty and -DefaultView [Table | List | Wide])
  • Add a test for dynamic loading of format view definitions.
  • Look into deduplicating format data entries in db.
  • Add more tests.

PR Context

I wanted to format objects in PowerShell, but found out that can only be done reliably through providing a .ps1xml file.
There is no easier way. I wrote about that here: https://joskw.gitbook.io/blog/object_formatting
And I found this issue #7845, which describes the problem.

PR Checklist

@ghost ghost assigned anmenaga Nov 29, 2020
@Jawz84
Copy link
Contributor Author

Jawz84 commented Nov 29, 2020

@anmenaga Hi Andrew, can you help me get a review of the work so far, so I know if this is up to par? Thanks!

@Jawz84 Jawz84 marked this pull request as ready for review November 29, 2020 20:07
@anmenaga anmenaga added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 2, 2020
@anmenaga
Copy link
Contributor

anmenaga commented Dec 2, 2020

Overall this looks up to par to me. Couple of notes:

  1. "WIP" must be removed from PR title (and corresponding checkbox in PR Checklist checked) before anybody will start in-depth review of the code. This is just this repo's process. "WIP" means "code changes in PR are not complete / not ready for review" therefore it does not make sense for people to spend time reviewing "WIP" PRs.
  2. "Documentation needed" is checked; in addition please follow that link and file an issue (something like "Need to document new Update-FormatData parameters") in PowerShell-Docs repository that links back to this PR; and add the link to that doc issue in "Issue filed:"
  3. what is meant by "Look into deduplicating format data entries in db." ?

PS. Thank you for picking up this work.

@ghost ghost added the Review - Needed The PR is being reviewed label Dec 9, 2020
@ghost
Copy link

ghost commented Dec 9, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw daxian-dbw added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels May 15, 2023
@ghost ghost added the Stale label May 30, 2023
@ghost
Copy link

ghost commented May 30, 2023

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Jun 9, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Stale Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supported way to load ExtendedTypeDefinition
3 participants