Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GetFiles in AnalysisCache #14326

Merged
merged 1 commit into from Jan 10, 2021
Merged

Replace GetFiles in AnalysisCache #14326

merged 1 commit into from Jan 10, 2021

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Dec 5, 2020

Contributes to #14318.

@ghost ghost assigned daxian-dbw Dec 5, 2020
@xtqqczze xtqqczze changed the title Avoid array allocations from GetDirectories/GetFiles. Replace GetFiles in AnalysisCache Dec 5, 2020
@xtqqczze xtqqczze closed this Dec 5, 2020
@xtqqczze xtqqczze reopened this Dec 5, 2020
@daxian-dbw daxian-dbw added the CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log label Dec 12, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 19, 2020
@ghost
Copy link

ghost commented Dec 19, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov assigned iSazonov and unassigned daxian-dbw Jan 10, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 10, 2021
@iSazonov iSazonov merged commit 8315515 into PowerShell:master Jan 10, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.3 milestone Jan 10, 2021
@xtqqczze xtqqczze deleted the getfiles-AnalysisCache branch January 18, 2021 08:05
@ghost
Copy link

ghost commented Feb 12, 2021

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees

@iSazonov iSazonov

Labels
CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log
Projects
None yet
Milestone
7.2.0-preview.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xtqqczze @daxian-dbw @iSazonov