New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix third party signing for files in sub-folders #14751
Merged
adityapatwardhan
merged 5 commits into
PowerShell:master
from
TravisEz13:fix-signing-for-preview
Feb 10, 2021
Merged
Fix third party signing for files in sub-folders #14751
adityapatwardhan
merged 5 commits into
PowerShell:master
from
TravisEz13:fix-signing-for-preview
Feb 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
requested review from
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
February 10, 2021 02:13
ghost
assigned daxian-dbw
Feb 10, 2021
adityapatwardhan
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
adityapatwardhan
added
the
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
label
Feb 10, 2021
adityapatwardhan
added
BackPort-7.1.x-Done
Backport to 7.1.x completed
and removed
BackPort-7.1.x-Consider
labels
Feb 10, 2021
daxian-dbw
pushed a commit
to daxian-dbw/PowerShell
that referenced
this pull request
Feb 11, 2021
daxian-dbw
pushed a commit
to daxian-dbw/PowerShell
that referenced
this pull request
Feb 11, 2021
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport-7.0.x-Done
BackPort-7.1.x-Done
Backport to 7.1.x completed
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix third party signing for files in sub-folders
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.