Remove unnecessary `Array` -> `List` -> `Array` conversion in `ProcessBaseCommand.AllProcesses` #15052

xtqqczze · 2021-03-17T14:43:37Z

PR Summary

Removes redundant code from ProcessBaseCommand.AllProcesses left after functionality was removed in remove -computer parameter from get-process #4960.
Simplify and use coalesce compound assignment (like in Enable IDE0074: Use coalesce compound assignment #13396)
Update documentation comments for style.

PR Context

Follow-up to #4960.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- [NA] Experimental feature(s) needed
  - [NA] Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- [NA] Documentation needed
  - [NA] Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- [NA] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
  - [NA] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
    (which runs in a different PS Host).
    - [NA] Issue filed:
  - [NA] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    - [NA] Issue filed:
  - [NA] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    - [NA] Issue filed:
  - [NA] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
    - [NA] Issue filed:

Change removes redundant code from ProcessBaseCommand.AllProcesse that was left after existing functionality was removed in PowerShell#4960.

rjmholt · 2021-03-17T16:54:06Z

Waiting on review from @daxian-dbw or @adityapatwardhan

ghost · 2021-03-31T02:00:06Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

xtqqczze · 2021-04-06T11:22:32Z

@TravisEz13 Can you approve changes?

TravisEz13 · 2021-04-10T16:28:43Z

@xtqqczze I'm not the reviewer for these changes. @rjmholt is the maintainer assigned to this.

ghost · 2021-04-14T23:58:41Z

🎉v7.2.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

@davidBar-On

[7.2.0-preview.5] - 2021-04-14 * Breaking Changes - Make PowerShell Linux deb and RPM packages universal (#15109) - Enforce AppLocker Deny configuration before Execution Policy Bypass configuration (#15035) - Disallow mixed dash and slash in command line parameter prefix (#15142) (Thanks @davidBar-On!) * Experimental Features - `PSNativeCommandArgumentPassing`: Use `ArgumentList` for native executable invocation (breaking change) (#14692) * Engine Updates and Fixes - Add `IArgumentCompleterFactory` for parameterized `ArgumentCompleters` (#12605) (Thanks @powercode!) * General Cmdlet Updates and Fixes - Fix SSH remoting connection never finishing with misconfigured endpoint (#15175) - Respect `TERM` and `NO_COLOR` environment variables for `$PSStyle` rendering (#14969) - Use `ProgressView.Classic` when Virtual Terminal is not supported (#15048) - Fix `Get-Counter` issue with `-Computer` parameter (#15166) (Thanks @krishnayalavarthi!) - Fix redundant iteration while splitting lines (#14851) (Thanks @hez2010!) - Enhance `Remove-Item -Recurse` to work with OneDrive (#14902) (Thanks @iSazonov!) - Change minimum depth to 0 for `ConvertTo-Json` (#14830) (Thanks @kvprasoon!) - Allow `Set-Clipboard` to accept empty string (#14579) - Turn on and off `DECCKM` to modify keyboard mode for Unix native commands to work correctly (#14943) - Fall back to `CopyAndDelete()` when `MoveTo()` fails due to an `IOException` (#15077) * Code Cleanup <details> <summary> We thank the following contributors! @xtqqczze, @iSazonov, @ZhiZe-ZG </summary> <ul> <li>Update .NET to <code>6.0.0-preview.3</code> (#15221)</li> <li>Add space before comma to hosting test to fix error reported by <code>SA1001</code> (#15224)</li> <li>Add <code>SecureStringHelper.FromPlainTextString</code> helper method for efficient secure string creation (#14124) (Thanks @xtqqczze!)</li> <li>Use static lambda keyword (#15154) (Thanks @iSazonov!)</li> <li>Remove unnecessary <code>Array</code> -> <code>List</code> -> <code>Array</code> conversion in <code>ProcessBaseCommand.AllProcesses</code> (#15052) (Thanks @xtqqczze!)</li> <li>Standardize grammar comments in Parser.cs (#15114) (Thanks @ZhiZe-ZG!)</li> <li>Enable <code>SA1001</code>: Commas should be spaced correctly (#14171) (Thanks @xtqqczze!)</li> <li>Refactor <code>MultipleServiceCommandBase.AllServices</code> (#15053) (Thanks @xtqqczze!)</li> </ul> </details> * Tools - Use Unix line endings for shell scripts (#15180) (Thanks @xtqqczze!) * Tests - Add the missing tag in Host Utilities tests (#14983) - Update `copy-props` version in `package.json` (#15124) * Build and Packaging Improvements <details> <summary> We thank the following contributors! @JustinGrote </summary> <ul> <li>Fix <code>yarn-lock</code> for <code>copy-props</code> (#15225)</li> <li>Make package validation regex accept universal Linux packages (#15226)</li> <li>Bump NJsonSchema from 10.4.0 to 10.4.1 (#15190)</li> <li>Make MSI and EXE signing always copy to fix daily build (#15191)</li> <li>Sign internals of EXE package so that it works correctly when signed (#15132)</li> <li>Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4 (#15141)</li> <li>Update daily release tag format to work with new Microsoft Update work (#15164)</li> <li>Feature: Add Ubuntu 20.04 Support to install-powershell.sh (#15095) (Thanks @JustinGrote!)</li> <li>Treat rebuild branches like release branches (#15099)</li> <li>Update WiX to 3.11.2 (#15097)</li> <li>Bump NJsonSchema from 10.3.11 to 10.4.0 (#15092)</li> <li>Allow patching of preview releases (#15074)</li> <li>Bump Newtonsoft.Json from 12.0.3 to 13.0.1 (#15084, #15085)</li> <li>Update the <code>minSize</code> build package filter to be explicit (#15055)</li> <li>Bump NJsonSchema from 10.3.10 to 10.3.11 (#14965)</li> </ul> </details> * Documentation and Help Content - Merge `7.2.0-preview.4` changes to master (#15056) - Update `README` and `metadata.json` (#15046) - Fix broken links for `dotnet` CLI (#14937) [7.2.0-preview.5]: v7.2.0-preview.4...v7.2.0-preview.5

xtqqczze added 4 commits March 17, 2021 13:28

Remove unnecessary Array -> List -> Array conversion

8316bed

Change removes redundant code from ProcessBaseCommand.AllProcesse that was left after existing functionality was removed in PowerShell#4960.

Fix IDE0025: Use expression body

f8f8550

Remove redundant initialization

2552ca3

Update documentation comments

1e2a12f

xtqqczze requested review from adityapatwardhan and daxian-dbw as code owners March 17, 2021 14:43

ghost assigned rjmholt Mar 17, 2021

xtqqczze mentioned this pull request Mar 17, 2021

Refactor MultipleServiceCommandBase.AllServices #15053

Merged

8 tasks

rjmholt approved these changes Mar 17, 2021

View reviewed changes

iSazonov approved these changes Mar 17, 2021

View reviewed changes

iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Mar 17, 2021

xtqqczze changed the title ~~Remove unnecessary Array -> List -> Array conversion in ProcessBaseCommand.AllProcesses~~ Remove unnecessary Array -> List -> Array conversion in ProcessBaseCommand.AllProcesses Mar 23, 2021

ghost added the Review - Needed The PR is being reviewed label Mar 31, 2021

ghost removed the Review - Needed The PR is being reviewed label Apr 10, 2021

rjmholt merged commit be9b14a into PowerShell:master Apr 12, 2021

iSazonov added this to the 7.2.0-preview.5 milestone Apr 12, 2021

xtqqczze deleted the cleanup-ProcessBaseCommand.AllProcesses branch April 12, 2021 18:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unnecessary `Array` -> `List` -> `Array` conversion in `ProcessBaseCommand.AllProcesses` #15052

Remove unnecessary `Array` -> `List` -> `Array` conversion in `ProcessBaseCommand.AllProcesses` #15052

xtqqczze commented Mar 17, 2021 •

edited

Loading

rjmholt commented Mar 17, 2021

ghost commented Mar 31, 2021

xtqqczze commented Apr 6, 2021

TravisEz13 commented Apr 10, 2021

ghost commented Apr 14, 2021

Remove unnecessary Array -> List -> Array conversion in ProcessBaseCommand.AllProcesses #15052

Remove unnecessary Array -> List -> Array conversion in ProcessBaseCommand.AllProcesses #15052

Conversation

xtqqczze commented Mar 17, 2021 • edited Loading

PR Summary

PR Context

PR Checklist

rjmholt commented Mar 17, 2021

ghost commented Mar 31, 2021

xtqqczze commented Apr 6, 2021

TravisEz13 commented Apr 10, 2021

ghost commented Apr 14, 2021

Remove unnecessary `Array` -> `List` -> `Array` conversion in `ProcessBaseCommand.AllProcesses` #15052

Remove unnecessary `Array` -> `List` -> `Array` conversion in `ProcessBaseCommand.AllProcesses` #15052

xtqqczze commented Mar 17, 2021 •

edited

Loading