New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty guid in HelpModuleInfo when module is CoreSnapin #15551
base: master
Are you sure you want to change the base?
Allow empty guid in HelpModuleInfo when module is CoreSnapin #15551
Conversation
…hen module is CoreSnapin
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
@davidBar-On Please have a look at merge conflict |
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Cached-up with master and resolved the merge conflicts. |
We definitely don't want a conditional assert, if the assert is not always true than it should not be an assert. I think the fix by @JamesWTruher is correct. |
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
PR Summary
Suggested fix for issue #15353. The root cause of the problem is the call to
UpdatableHelpModuleInfo
withGUID.Empty
in case module isInitialSessionState.CoreSnapin
. However, that conflics with the assertions for empty GUID inUpdatableHelpModuleInfo
andUpdatableHelpUri
. As described in #15353 the problem happens in my computer in both Windows and WSL environments.The suggested fix is actually a workaround that doesn't perform the assertion in case the module is
InitialSessionState.CoreSnapin
. It may be that the right approach is to eliminate the use ofGUID.Empty
.No automatic tests were added as I don't understand what is causing the problem in my computer, but probably not in most other environments.
PR Context
Hard code calling
UpdatableHelpModuleInfo
withGUID.Empty
conflicts with the assertion that the GUID should not be empty.PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).