Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFC 277: native error throwing #15897

Merged
merged 47 commits into from
Aug 24, 2021

Conversation

rjmholt
Copy link
Collaborator

@rjmholt rjmholt commented Aug 9, 2021

PR Summary

Continuation of @rkeithhill's work in #15757.

Implements error throwing with error action preference integration for native executables, similar to set -e scenarios on *nix.

PR Context

See on PowerShell/PowerShell-RFC#277.

PR Checklist

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 23, 2021
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 24, 2021
continue
}

$hitTrap = $false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we explicitly create $exception in the scope too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it'll be $null by default, rather than $false, so we don't really need to

@daxian-dbw daxian-dbw merged commit a4d1457 into PowerShell:master Aug 24, 2021
hayhay27 pushed a commit to hayhay27/PowerShell that referenced this pull request Aug 25, 2021
@rjmholt rjmholt deleted the nativeerror-addressfeedback branch September 2, 2021 17:02
xtqqczze pushed a commit to xtqqczze/PowerShell that referenced this pull request Sep 2, 2021
@ghost
Copy link

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants