Remove duplicate remote server mediator code #16027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR removes duplicate server mediator classes, and refactors code to use a single mediator for StdIO based connections.
It also fixes parameter arguments so that configuration name is passed in correctly.
PR Context
There used to be two separate server mediator derivations, one each for OutOfProc and SSH transports. They both use StdIO for communication, but SSH had special code to deal with .NET implementation inconsistencies. But .NET addressed the issues and now both class derivations operate identically. So this PR creates a single StdIOProcessMediator class for both uses.
I also found a bug where the 'configurationName' parameter was not passed in correctly for HyperV mediators. I fixed the issues, but it turns out that the code path is not being used for PowerShellDirect VM connections, but I am not sure about container connections.
Actually, neither of these code paths are used because currently PowerShellDirect only works with WindowsPowerShell.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).