Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Term checking compliance task configuration #16034

Closed
wants to merge 0 commits into from

Conversation

TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Sep 1, 2021

PR Summary

Update Term checking compliance task configuration

  • Delete unused file (new tool deprecated the file type xml)
  • Update use of terms where tool found new issues.
  • Enable recursion (optionsXS = 1)
    • Exclude the .git folder

Make ForceAzureBlobDelete a parameter in the build pipeline.

PR Context

PR Checklist

@@ -79,12 +79,11 @@ jobs:
inputs:
targetType: F
optionsFC: 0
optionsXS: 0
optionsXS: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what is required for recursion. I believe that we need to set targetArgument instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, this option is required to be 1, but that is the default value. This usage of the task needs to not override it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing we do not use the Compliance repo, otherwise PowerShell/Compliance#28 would have fixed this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reopened as #16035

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Sep 1, 2021
@TravisEz13 TravisEz13 closed this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants