Set $? correctly for command expression with redirections

[daxian-dbw]

PR Summary

Fix #16033

This PR makes a small update to ShouldSetExecutionStatusToSuccess(PipelineAst) to not exclude single expression with redirections, so that $? can be set to true properly for single-element pipeline that only contains a command expression with redirections.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.

[vexx32]

Do we already have regression tests verifying that the (command) vs command still behaves as expected?

[daxian-dbw]

@iSazonov Thanks for adding the needed labels!
@vexx32 Are you concerned about the paren expression specifically? Can yo please provide a couple examples to show what you think could be regressed?

[vexx32]

The change that (seemingly) caused this one to crop up was the change for (Invoke-Cmd) where Invoke-Cmd would set $? to false if it fails, but in parentheses it would fail to set it correctly.

So I guess a test case would be:

function fail {
    [CmdletBinding()]
    param()
    try { throw } catch { $PSCmdlet.WriteError($_) }
}

fail
$? | Should -BeFalse
(fail)
$? | Should -BeFalse

[adityapatwardhan]

Backport rejected as this does not meet the bar. This will cause a change in behavior for 7.0.x and 7.1.x.

[daxian-dbw]

@vexx32 It still behaves as expected, but I don't know if we have such test already. I can add one if not.

[ghost]

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes