Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify exe path as TargetObect for non-zero exit code ErrorRecord #16108

Conversation

rkeithhill
Copy link
Collaborator

@rkeithhill rkeithhill commented Sep 15, 2021

PR Summary

This PR changes the TargetObject for the ErrorCode to the full native command's path. This ErrorRecord is generated as part of the experimental feature PSNativeCommandErrorActionPreference.

PR Context

Fix #15992

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Sep 16, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Sep 23, 2021
@ghost
Copy link

ghost commented Sep 23, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@rkeithhill
Copy link
Collaborator Author

@rjmholt Any chance you could give this a quick review? Also, since it appears we're still doing previews any chance we could get this whole experimental feature in for 7.2?

@rjmholt
Copy link
Collaborator

rjmholt commented Oct 7, 2021

@rkeithhill this experimental feature wasn't taken for 7.2 (since it came in late), so it and this PR will be released in 7.3 preview 1

@ghost ghost removed the Review - Needed The PR is being reviewed label Oct 7, 2021
@rkeithhill
Copy link
Collaborator Author

I can't merge this. @rjmholt or @iSazonov - can you merge this?

@rjmholt rjmholt merged commit b94dd91 into PowerShell:master Oct 14, 2021
@ghost
Copy link

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should native command errors have the executable path or invocation as the TargetObject instead of the name?
4 participants