Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticode https fix issue #12827 #16134

Merged

Conversation

ghost
Copy link

@ghost ghost commented Sep 22, 2021

PR Summary

A fix for issue #12827

PR Context

The Set-AuthenticodeSignature command only allows the use of an http timestamp server only. I added https:// as also a valid prefix.

PR Checklist

@ghost ghost assigned iSazonov Sep 22, 2021
@PaulHigin PaulHigin added WG-Security security related areas such as JEA Needs-Triage The issue is new and needs to be triaged by a work group. labels Sep 22, 2021
@ghost
Copy link

ghost commented Sep 22, 2021

CLA assistant check
All CLA requirements met.

@ghost ghost marked this pull request as ready for review September 22, 2021 17:48
@ghost ghost added the Review - Needed The PR is being reviewed label Sep 30, 2021
@ghost
Copy link

ghost commented Sep 30, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Oct 3, 2021
I agree.

Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 4, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 12, 2021
@ghost
Copy link

ghost commented Oct 12, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@PaulHigin
Copy link
Contributor

@Ryan-Hutchison-USAF Can you please make the change requested by @TravisEz13?

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 15, 2021
@PaulHigin PaulHigin removed the Needs-Triage The issue is new and needs to be triaged by a work group. label Nov 15, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 23, 2021
@ghost
Copy link

ghost commented Nov 23, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov closed this Jul 26, 2022
@iSazonov iSazonov reopened this Jul 26, 2022
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 26, 2022
@iSazonov
Copy link
Collaborator

@TravisEz13 Please update your review.

@TravisEz13 TravisEz13 merged commit f2204a0 into PowerShell:master Aug 1, 2022
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Aug 1, 2022
@ghost
Copy link

ghost commented Aug 12, 2022

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log WG-Security security related areas such as JEA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants