-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authenticode https fix issue #12827 #16134
Authenticode https fix issue #12827 #16134
Conversation
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
I agree. Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
@Ryan-Hutchison-USAF Can you please make the change requested by @TravisEz13? |
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
@TravisEz13 Please update your review. |
🎉 Handy links: |
PR Summary
A fix for issue #12827
PR Context
The Set-AuthenticodeSignature command only allows the use of an http timestamp server only. I added https:// as also a valid prefix.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).