Fix ValidateRange Max Depth Allowed

[KevRitchie]

PR Summary

Replace int.MaxValue with 100 so that parameter validation works as expected.

Remove BeginProcessing method. No longer required to do a prerequisite check on Max Depth. Parameter Argument Validation now used.

Update Json Tests.

PR Context

Fixes #15344

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • [] N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
      (which runs in a different PS Host).
      • Issue filed:
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Issue filed:
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Issue filed:
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
      • Issue filed:

[ghost]

All CLA requirements met.

[daxian-dbw]

@SteveL-MSFT can you please take a quick look?

[iSazonov]

I wonder why do we change the check if we get right error message? Also see #3181 - I wonder about it too.

[daxian-dbw]

The documentation is already up-to-date;

Specifies how many levels of contained objects are included in the JSON representation. The value can be any number from 1 to 100. The default value is 2. ConvertTo-Json emits a warning if the number of levels in an input object exceeds this number.

@iSazonov This is to fix the incorrect validate range attribute. While after fixing that, there is no need for explicit check.

[iSazonov]

The documentation is already up-to-date;

Specifies how many levels of contained objects are included in the JSON representation. The value can be any number from 1 to 100. The default value is 2. ConvertTo-Json emits a warning if the number of levels in an input object exceeds this number.

@iSazonov This is to fix the incorrect validate range attribute. While after fixing that, there is no need for explicit check.

I had reverse logic to keep PowerShell custom error message. :-) No objections to have ValidateRange error message.

[daxian-dbw]

The documentation is already up-to-date;

Actually, there is an inconsistency in the doc. -Depth supports argument 0, but the help content say from 1 to 100.
@sdwheeler, shall we update the doc?

[sdwheeler]

@daxian-dbw It supports a value of 0 but is it valid?

PS> get-date | convertto-json -Depth 0
ConvertTo-Json: Cannot validate argument on parameter 'Depth'. The 0 argument is less than the minimum allowed range of 1. Supply an argument that is greater than or equal to 1 and then try the command again.

The supported range should probably start at 1, not 0.

[daxian-dbw]

@sdwheeler It works on 7.2.0-preview.9, so I guess there was a change that made this work at some point.

[sdwheeler]

@daxian-dbw Ah, yeah. I think that was one of the things fixed. The docs for the cmdlet in 7.2 already list the range as 0..100.

[daxian-dbw]

Right, the 7.2 doc has the right content. Thanks @sdwheeler!

Specifies how many levels of contained objects are included in the JSON representation. The value can be any number from 0 to 100. The default value is 2. ConvertTo-Json emits a warning if the number of levels in an input object exceeds this number.

[ghost]

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes