New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an approval for releasing build-info json #16351
Add an approval for releasing build-info json #16351
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
🎉 Handy links: |
🎉 Handy links: |
/backport to release/v7.0.11 |
Started backporting to release/v7.0.11: https://github.com/PowerShell/PowerShell/actions/runs/2271011076
|
@TravisEz13 backporting to release/v7.0.11 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Add an approval for releasing build-info json
Using index info to reconstruct a base tree...
M tools/releaseBuild/azureDevOps/releasePipeline.yml
Falling back to patching base and 3-way merge...
Auto-merging tools/releaseBuild/azureDevOps/releasePipeline.yml
CONFLICT (content): Merge conflict in tools/releaseBuild/azureDevOps/releasePipeline.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add an approval for releasing build-info json
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
# Conflicts: # tools/releaseBuild/azureDevOps/releasePipeline.yml
🎉 Handy links: |
PR Summary
Add an approval check for releasing the build-info json
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).