Update docs/FAQ.md #1640
Update docs/FAQ.md #1640
Conversation
Fixing typos and formatting.
|
@raghushantha Please, review. |
TravisEz13
added
the
Area-Maintainers-Documentation
|
I restarted the tests. I don't see how it's an issue with the PR unless you need to rebase. |
|
I don't know what causes a problem. This PR doesn't have conflicts and it's created online using the latest version of the article. |
|
@alexandair, They all passed on rerun. It must have been an environmental issue like I thought. |
|
Great. Please, merge if changes are OK. |
| more information. | ||
| Error handling in PowerShell is a bit weird, as not all errors result in catchable exceptions by default. | ||
| Setting `$ErrorActionPreference = 'Stop'` will likely do what you want; | ||
| that is, cause non-terminating errors to instead terminate. |
There was a problem hiding this comment.
to instead terminate -> instead to terminate
The to-infinitive to terminate has been split by the modifier instead.
There was a problem hiding this comment.
I think you mean: "that is, it will cause non-terminating errors to terminate."
If you feel strongly about "instead" you should probably put it at the end. Something like: "Setting $ErrorActionPreference = 'Stop' will likely do what you want; that is, cause normally non-terminating errors to terminate instead."
|
Please update the PR template with the issue this resolves. |
|
I'm not aware of the issue we will resolve with this PR. |
|
Please be sure to open an issue for all PRs in the future and refer to it in the pull request template. This is required per our contribution guidelines. |
|
@TravisEz13 I don't follow you. I don't see anyone creating issues for PRs related to documentation. I couldn't find that in Contribution guidelines. Guidelines are different for PRs to docs and code. |
|
| download PowerShell (which it then uses to build and test through the | ||
| `build.psm1` module). However, the following caveat applies: | ||
| download PowerShell (which it then uses to build and test through the `build.psm1` module). | ||
| However, the following caveat applies: | ||
|
|
||
| > Encrypted variables are not added to untrusted builds such as pull requests | ||
| > coming from another repository. | ||
|
|
||
| Thus a pull request made from a fork of the PowerShell repository will not pass |
There was a problem hiding this comment.
This is no longer true either.
There was a problem hiding this comment.
@andschwa Could you open a PR to fix that?
|
@TravisEz13 I don't think that sentence states that we should first open an issue, and than open a PR to fix the issue as you are implying. If that's true then it should be stated clearly. As I've said earlier, I don't see anyone doing that. |
|
@alexandair We have recently changed the contribution guidelines and maintainers and starting reviewing for compliance with governance. First, I pointed to the area that said that you must follow the PR template, and you said that did not apply because this was a doc change. So, I pointed you to the guidance that said the rules of code PR's apply to doc PRs in this repo. Which includes this guidance ` Therefore, you should fill out the PR template and supply an issue (create one if it doesn't exist.) |
origin/master.Fixing typos and formatting.