New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Convert-Path for unknown drive in Build.psm1 #16416
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There is #13202 also. |
#13202 uses This PR uses |
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
@matt9ucci Thanks for your contribution. |
🎉 Handy links: |
PR Summary
Fix #13201
PR Context
If we are at
Temp:\
,$PWD.Path
returnsTemp:\
, unknown PSDrive for Windows PowerShell.Instead,
Convert-Path -Path $PWD.Path
returns a standard FileSystem path likeC:\Users\me\AppData\Local\Temp\
. It can be handled by Windows PowerShell.PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.