Make Measure-Object ignore missing properties unless running in strict mode

[KiwiThePoodle]

PR Summary

When using Measure-Object on an empty folder, the "Length" property is invalid. When in StrictMode, an error is thrown when the requested property is not found. The error message is also updated to include the specific property that is not found. The invalid property is simply ignored when not in StrictMode.

PR Context

Fixes issue #14449
Unless in StrictMode, missing properties are typically ignored by other commands, so the Measure-Object command should do the same. This pull-request updates the Measure-Object command to only throw a property not found error when in StrictMode and ignores the property not found when not in StrictMode. This functionality is now consistent with other PowerShell commands.

PR Steps to Reproduce

my_folder is an empty directory

When StrictMode is off: no error
Set-StrictMode -off
gi my_folder | measure Length -sum

When StrictMode is on: error message
Set-StrictMode -Version 3.0
gi my_folder | measure Length -sum

Measure-Object: Cannot process argument because the value of argument “Length” is not valid. Change the value of the “Length” argument and run the operation again.

PR Changed Files

Measure-Object.cs
-Bug fix: changed "Property" to propertyName, the actual name of the property argument
-WritePropertyNotFoundError(propertyName, errorId) only called when in StrictMode

Measure-Object.Tests.ps1
-Added 2 empty folder tests where Measure-Object command is used on an empty folder
-When not in StrictMode, no error should be thrown
-When in StrictMode, error should be thrown

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
      (which runs in a different PS Host).
      • Issue filed:
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Issue filed:
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Issue filed:
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
      • Issue filed:

[ghost]

All CLA requirements met.

[iSazonov]

This should be after BeforeAll.

[iSazonov]

Up!

[KiwiThePoodle]

I am a little confused by this suggestion.

[iSazonov]

In all our tests files are formatted so

PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Service.Tests.ps1

Lines 3 to 15 in 7bebf44

	Describe "Get-Service cmdlet tests" -Tags "CI" {
	# Service cmdlet is currently working on windows only
	# So skip the tests on non-Windows
	BeforeAll {
	$originalDefaultParameterValues = $PSDefaultParameterValues.Clone()
	if ( -not $IsWindows ) {
	$PSDefaultParameterValues["it:skip"] = $true
	}
	}
	# Restore the defaults
	AfterAll {
	$global:PSDefaultParameterValues = $originalDefaultParameterValues
	}

[KiwiThePoodle]

Ah, I see, thank you

[iSazonov]

@KiwiThePoodle Please rebase to fix CI-static.

[ghost]

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

[daxian-dbw]

I spot this when trying to merge approved PRs on behalf of @TravisEz13, who is OOF this week.
@KiwiThePoodle can you please address this comment?

[pull-request-quantifier-deprecated]

This PR has 18 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Extra Small
Size       : +14 -4
Percentile : 7.2%

Total files changed: 2

Change summary by file extension:
.cs : +5 -4
.ps1 : +9 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer
    iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detetcted.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will
  interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification)
  of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

[daxian-dbw]

Thanks @KiwiThePoodle for your contribution!

[ghost]

🎉v7.3.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes