New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix $PSNativeCommandArgPassing
= Windows
to handle empty args correctly
#16639
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 Handy links: |
PR Summary
When the new
Windows
mode was added to$PSNativeCommandArgPassing
, the PR didn't change some of the logic as it only expectedStandard
andLegacy
. The intent was thatWindows
would beStandard
, but have exception to fallback toLegacy
for a specific set of extensions and executables to maintain compatibility. This resulted inWindows
having theLegacy
behavior when it came to empty args which get dropped. The fix is to change the handling so instead of checking forStandard
it checks if it's notLegacy
.PR Context
Brought to my attention by .NET team member
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.PSNativeCommandArgumentPassing
(which runs in a different PS Host).