New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a couple fixes to generic method invocation #16822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 Can't believe I didn't catch that... does that mean none of the tests in that file were running, then? Glad you caught that!
The changes here look good to me on the surface, thanks for adding this in! 💖
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
What about generic constraint violations? e.g. [enum]::GetName[object]([object]::new()) Calling
Is that surfaced? |
I was expecting the generic method not found message so I'll take it! 😁 |
PR Summary
Fix #16809
Follow up on #12412
Add a couple fixes to generic method invocation:
@vexx32 It turns out the tests you added didn't run at all because of this:
PowerShell/test/powershell/Language/Parser/MethodInvocation.Tests.ps1
Lines 3 to 5 in 8af0834
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.