Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sles15 support to install-powershell.sh #16984

Merged
merged 1 commit into from May 12, 2022

Conversation

yogeshbirla
Copy link
Contributor

Script today fails for SLES15 because of some outdated code written for Sles12. This is fixed by using the correct command from /etc/os-release for all SUSE distros.

@pull-request-quantifier-deprecated

This PR has 15 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +9 -6
Percentile : 6%

Total files changed: 2

Change summary by file extension:
.sh : +9 -6

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost
Copy link

ghost commented Mar 10, 2022

CLA assistant check
All CLA requirements met.

@iSazonov
Copy link
Collaborator

@yogeshbirla Please use our PR template for first post.

@daxian-dbw daxian-dbw assigned TravisEz13 and unassigned daxian-dbw Mar 10, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Mar 18, 2022
@ghost
Copy link

ghost commented Mar 18, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@RamiSJ12
Copy link

RamiSJ12 commented Mar 27, 2022

you can get it from the server here...
https://www.suse.com/download/sles/

Try our free download of SUSE Linux Enterprise Server and get 60 days of free patches and maintenance.

@TravisEz13 TravisEz13 changed the title Add sles15 support Add sles15 support to install-powershell.sh May 12, 2022
@TravisEz13 TravisEz13 enabled auto-merge (squash) May 12, 2022 17:15
@TravisEz13
Copy link
Member

/azp run Powershell-CI-macos

@ghost ghost removed the Review - Needed The PR is being reviewed label May 12, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TravisEz13 TravisEz13 added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label May 12, 2022
@TravisEz13 TravisEz13 merged commit 30f4b82 into PowerShell:master May 12, 2022
@ghost
Copy link

ghost commented May 23, 2022

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Tools Indicates that a PR should be marked as a tools change in the Change Log Extra Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants