New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create checksum file for global tools #17056
Create checksum file for global tools #17056
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Test build to verify the new checksum file: https://dev.azure.com/mscodehub/PowerShellCore/_build/results?buildId=250887&view=logs&j=b68f2f44-6987-572d-9dbb-1c96660ee23d&t=815f2ee4-ed58-5f9d-3b75-921a3c1e1e34&l=35 |
This change should be backported to 7.0, 7.1 and 7.2. It is being marked accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -222,9 +222,36 @@ jobs: | |||
Write-Verbose -Verbose -Message $fileContent | |||
|
|||
Copy-Item -Path "$packagePath\SHA512SUMS" -Destination '$(System.ArtifactsDirectory)\signed\' -verbose | |||
Copy-Item -Path "$packagePath\SHA512SUMS" -Destination '$(System.ArtifactsDirectory)\signed\globaltool\' -verbose | |||
displayName: Generate checksum file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
displayName: Generate checksum file | |
displayName: Generate checksum file for packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adityapatwardhan Can you please address this comment? I can merge afterwards.
🎉 Handy links: |
🎉 Handy links: |
) Cherry-picking the checksum change: PowerShell#17056
🎉 Handy links: |
PR Summary
During refactoring of nuget.yml for SBOM changes, creating checksum for global tool packages was missed. This change adds back creation of a checksum file for global tool packages.
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).