New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not generate clean block in proxy command when the feature is disabled #17112
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This breaks JEA as it uses RestrictedSessions, so we should consider for backport. |
The |
🎉 Handy links: |
PR Summary
Fix #17110
When the
PSCleanBlock
experimental feature is not enabled,ProxyCommand.Create
should not generate the clean block for the proxy function.After the fix,
when the feature is disabled, generated proxy function for
Get-Command
doesn't have theclean
block in it:When the feature is enabled, the generated proxy function for
Get-Command
has theclean
block in it:PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.