New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed package names verification to support multi-digit versions #17220
Fixed package names verification to support multi-digit versions #17220
Conversation
…git versions Fixed package names verification to support multi-digit versions. Currently "Validate RPM package names" release step is failing because of version "7.0.10" in these examples: WARNING: powershell-7.0.10-1.centos.8.x86_64.rpm is not a valid package name WARNING: powershell-7.0.10-1.rhel.7.x86_64.rpm is not a valid package name WARNING: powershell-lts-7.0.10-1.centos.8.x86_64.rpm is not a valid package name WARNING: powershell-lts-7.0.10-1.rhel.7.x86_64.rpm is not a valid package name
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
🎉 Handy links: |
🎉 Handy links: |
) Fixed package names verification to support multi-digit versions. Currently "Validate RPM package names" release step is failing because of version "7.0.10" in these examples: WARNING: powershell-7.0.10-1.centos.8.x86_64.rpm is not a valid package name WARNING: powershell-7.0.10-1.rhel.7.x86_64.rpm is not a valid package name WARNING: powershell-lts-7.0.10-1.centos.8.x86_64.rpm is not a valid package name WARNING: powershell-lts-7.0.10-1.rhel.7.x86_64.rpm is not a valid package name
PR Summary
Copying this change from release branch of v7.0.10
PR Context
Fixed package names verification to support multi-digit versions.
Currently "Validate RPM package names" release step is failing because of version "7.0.10" in these examples:
WARNING: powershell-7.0.10-1.centos.8.x86_64.rpm is not a valid package name
WARNING: powershell-7.0.10-1.rhel.7.x86_64.rpm is not a valid package name
WARNING: powershell-lts-7.0.10-1.centos.8.x86_64.rpm is not a valid package name
WARNING: powershell-lts-7.0.10-1.rhel.7.x86_64.rpm is not a valid package name
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).