Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container to Linux CI #17233

Merged
merged 64 commits into from May 2, 2022
Merged

Conversation

TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Apr 29, 2022

PR Summary

Add a test in a container to allow broader distribution testing in CI:

  1. Add a mechanism to query and select an image from the docker repo, currently hard coded to select mariner.
  2. add a new template which supports running tests in a container
    • Steps were moved to a new template so that the templates share as much as possible.
  3. fix tests so they pass on mariner

PR Context

PR Checklist

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 2, 2022
.vsts-ci/linux.yml Outdated Show resolved Hide resolved
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 2, 2022
TravisEz13 and others added 2 commits May 2, 2022 11:21
Co-authored-by: James Truher [MSFT] <jimtru@microsoft.com>
Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisEz13

This comment was marked as outdated.

@azure-pipelines

This comment was marked as duplicate.

@TravisEz13
Copy link
Member Author

/azp run PowerShell-CI-windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines

This comment was marked as outdated.

@TravisEz13 TravisEz13 marked this pull request as ready for review May 2, 2022 21:44
@pull-request-quantifier-deprecated

This PR has 307 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +183 -124
Percentile : 70.7%

Total files changed: 11

Change summary by file extension:
.yml : +146 -75
.ps1 : +10 -41
.psd1 : +1 -0
.psm1 : +26 -8

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 merged commit 156757c into PowerShell:master May 2, 2022
@TravisEz13 TravisEz13 deleted the add-mariner branch May 3, 2022 18:28
@ghost
Copy link

ghost commented May 23, 2022

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13
Copy link
Member Author

We should only backport the wsman test fixes to 7.2

TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request Jun 7, 2022
@TravisEz13 TravisEz13 mentioned this pull request Jun 7, 2022
22 tasks
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants