New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix list view to not leak VT decorations #17262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ❤️
Can we split the build.psm1 change into a different PR. We may want to backport this in the future. Also should the VT leak fix be taken to 7.2? |
@adityapatwardhan Sure, will split the build.psm1 changes to a separate PR. I don't think this VT fix should be backported, this doesn't seem to be a big issue by telling from the report. But if we decided to take #17251, then this one should also be taken. |
@adityapatwardhan The changes to |
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
🎉 Handy links: |
PR Summary
Fix #17157
Fix list view to not leak VT decorations.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.