-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Milliseconds Parameter to New-TimeSpan #17621
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
@PaulHigin It looks like the only failed test asking me to do something that would make the comment for this property inconsistent with the rest of the comments on the other properties. Let me know if you want me to change them all or if we can ignore this check. |
@NoMoreFood CodeFactor Ci is not mandatory. I am ok to keep consistency with over doc comments. |
@NoMoreFood Please create new issue in Docs repository and add reference in OP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :-)
@NoMoreFood Thanks for your contribution! |
🎉 Handy links: |
PR Summary
This PR adds a parameter to the New-TimeSpan cmdlet and updates the tests associated with the cmdlet to accomadate testing the new parameter.
PR Context
The ability to set millisecond precision in a timespan structure could be beneficial where consumers of a timespan structure have millisecond resolution. This was requested under issue #16486.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).