-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render decimal numbers in a table using current culture #17650
Conversation
src/System.Management.Automation/FormatAndOutput/common/Utilities/MshObjectUtil.cs
Outdated
Show resolved
Hide resolved
…ies/MshObjectUtil.cs
test/powershell/Modules/Microsoft.PowerShell.Utility/Format-List.Tests.ps1
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Format-Table.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Format-Table.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Format-List.Tests.ps1
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/Utilities/MshObjectUtil.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/Utilities/MshObjectUtil.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/Utilities/MshObjectUtil.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/Utilities/MshObjectUtil.cs
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/FormatViewGenerator_Table.cs
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/Utilities/MshObjectUtil.cs
Outdated
Show resolved
Hide resolved
…ble.Tests.ps1 Co-authored-by: Ilya <darpa@yandex.ru>
…ble.Tests.ps1 Co-authored-by: Ilya <darpa@yandex.ru>
…st.Tests.ps1 Co-authored-by: Ilya <darpa@yandex.ru>
…ies/MshObjectUtil.cs Co-authored-by: Ilya <darpa@yandex.ru>
…ies/MshObjectUtil.cs Co-authored-by: Ilya <darpa@yandex.ru>
…ies/MshObjectUtil.cs Co-authored-by: Ilya <darpa@yandex.ru>
…ViewGenerator_Table.cs Co-authored-by: Ilya <darpa@yandex.ru>
…ies/MshObjectUtil.cs Co-authored-by: Ilya <darpa@yandex.ru>
@SteveL-MSFT Please remove |
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
🎉 Handy links: |
PR Summary
Previously, decimal numbers are rendered in tables with all of the decimal places. This is not as useful in Tables where number alignment and minimal number of decimal places can provide more and easier to read information. The change here is only for
Format-Table
where decimal, float, and double values use the user's current culture set for NumberDecimalDigits is applied.Since this only affects formatting and not the actual value, this is not a breaking change.
PR Context
Fix #17544
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).
17544