-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dynamic parameter tab completion #17661
Improve dynamic parameter tab completion #17661
Conversation
src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilya <darpa@yandex.ru>
src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs
Outdated
Show resolved
Hide resolved
…doParameterBinder.cs
@MartinGC94 Please look CI fails. |
The CI fails don't make any sense to me. My branch is 7 days old and the |
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Look like a bug in CI workflow. Ping @TravisEz13 and @adityapatwardhan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 Handy links: |
PR Summary
Fixes #9983
Fixes #3189
Fixes #5326
This makes the pseudo parameter binder use the expression value if it's a constant expression rather than the raw Ast text. This removes the need for special handling by dynamic parameters for "quoted" VS. "unquoted" strings.
Get-ChildItem did not handle this properly so this:
Get-ChildItem -Path "C:\" -<Tab>
wouldn't show the filesystem provider parameters butGet-ChildItem -Path C:\ -<Tab>
would.PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).