Fix test performance by stopping ongoing progress-bar #17749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
A progress-bar started in
ActionPreference.Tests.ps1
is never completed and causes the the progress-bar to be rendered for all remaining tests including other files, killing the performance.PR Context
Demo command:
Start-PSPester -SkipTestToolBuild -Path /workspaces/PowerShell/test/powershell/Language/Scripting/ActionPreference.Tests.ps1, /workspaces/PowerShell/test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1
Before change: 60-70s
After change: 16s
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).