Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent braces from being removed when completing variables #17751

Conversation

MartinGC94
Copy link
Contributor

@MartinGC94 MartinGC94 commented Jul 23, 2022

PR Summary

Adds additional check for adding braces to the variable completion result if the user input includes braces. This fixes variable completion inside strings like: "Hello${psversiont<Tab>}World".
Also makes Null-conditional operator usage with variables slightly more convenient because tab completion won't remove the necessary braces from the variable name.

PR Context

PR Checklist

@ghost ghost assigned anmenaga Jul 23, 2022
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 24, 2022
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit 8eb37cc into PowerShell:master Jul 25, 2022
@ghost
Copy link

ghost commented Aug 12, 2022

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants