New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispose TraceSources when they're not used any more #18205
base: master
Are you sure you want to change the base?
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Is it actually too large @iSazonov? Most of the lines are just affected because of indentation. |
It is ok. We can hide white spaces https://github.com/PowerShell/PowerShell/pull/18205/files?diff=split&w=1 |
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
PR Summary
Please hide white spaces at review https://github.com/PowerShell/PowerShell/pull/18205/files?diff=split&w=1
A few previously non-disposed
PowerShellTraceSourcEe
instances are now being disposed correctly when they go out of scope.PR Context
This change improves the handling of disposable objects (ie. implementing
IDisposable
) in accordance with the default implementation pattern. Partly addresses the currently disable compiler warnings of the CA2213 and CA2215 type. Partially addresses the violations mentioned in #15803.PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).