New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase timeout to make subsystem tests more reliable #18380
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
🎉 Handy links: |
🎉 Handy links: |
PR Summary
Increase timeout to make subsystem tests more reliable.
PR Context
The
CommandPrediction
xUnit tests have been failing for the last 2 days because the expected operation cannot finish before the timeout. The expected operation is done via tasks using the thread pool. xUnit itself generates a lot of tasks backed by thread pool, which makes the task run unpredictable comparing with the real scenario.The old timeout has been working well until very recently (2 days ago), and it may be caused by changes in the CI agent or activities involved in the CI pipeline.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.