New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply expected file permissions to linux files after authenticode signing #18643
Apply expected file permissions to linux files after authenticode signing #18643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6c7a584
to
06fc605
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
/backport to release/v7.3.1 |
🎉 Handy links: |
/backport to release/v7.2.9 |
This comment was marked as outdated.
This comment was marked as outdated.
…ning (PowerShell#18643) * Upload linux artifacts as tar.gz to preserve linux file permissions * Fix conditions * Fix yaml * Fix paths for downloaded artifacts * Rename while downloading * Fix file names and paths * Fix tar compress * Add set-location before tar * Create dirs before expanding * Create dir before expanding * Fix conditions * Add logging * Export file permission to json * Fix for condition * Apply file permissions before packaging * Add logging * Fix issues * Add comments
/backport to release/v7.2.9 |
…ning (PowerShell#18643) * Upload linux artifacts as tar.gz to preserve linux file permissions * Fix conditions * Fix yaml * Fix paths for downloaded artifacts * Rename while downloading * Fix file names and paths * Fix tar compress * Add set-location before tar * Create dirs before expanding * Create dir before expanding * Fix conditions * Add logging * Export file permission to json * Fix for condition * Apply file permissions before packaging * Add logging * Fix issues * Add comments
…ning (PowerShell#18643) * Upload linux artifacts as tar.gz to preserve linux file permissions * Fix conditions * Fix yaml * Fix paths for downloaded artifacts * Rename while downloading * Fix file names and paths * Fix tar compress * Add set-location before tar * Create dirs before expanding * Create dir before expanding * Fix conditions * Add logging * Export file permission to json * Fix for condition * Apply file permissions before packaging * Add logging * Fix issues * Add comments
PR Summary
When trying to authenticode sign files on Windows the linux file permissions are lost. We store them in a json file and then re-apply them.
Fixes #18495
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).