Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixes for stabilizing tests #19068

Merged
merged 30 commits into from Mar 13, 2023

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Jan 31, 2023

PR Summary

Make tests more robust when executing on various platforms.

PR Context

PR Checklist

<Reference Include="System.Management.Automation">
<HintPath>.\Ref\System.Management.Automation.dll</HintPath>
</Reference>
<PackageReference Include="System.Management.Automation" Version="7.4.0-preview.1" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be automated in some way?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I will add this csproj to the dependabot monitored csproj files

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 4, 2023
@adityapatwardhan
Copy link
Member Author

This PR is under test. Commenting so bot doesnt close the PR.

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Feb 9, 2023
@ghost ghost added the Stale label Mar 1, 2023
@ghost
Copy link

ghost commented Mar 1, 2023

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@adityapatwardhan adityapatwardhan marked this pull request as ready for review March 10, 2023 18:56
@ghost ghost removed the Stale label Mar 10, 2023
@adityapatwardhan adityapatwardhan changed the title WIP: Test fixes for stabilizing tests Test fixes for stabilizing tests Mar 10, 2023
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 10, 2023
@adityapatwardhan
Copy link
Member Author

Removed the change adding the asset and also the change setting timeout for the pipeline task

@pull-request-quantifier-deprecated

This PR has 261 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +203 -58
Percentile : 66.1%

Total files changed: 19

Change summary by file extension:
.psm1 : +38 -12
.json : +4 -2
.ps1 : +157 -41
.psd1 : +3 -0
.csproj : +1 -3

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@adityapatwardhan adityapatwardhan merged commit e95f7fb into PowerShell:master Mar 13, 2023
44 checks passed
@adityapatwardhan adityapatwardhan deleted the RaFixes_1 branch March 13, 2023 22:40
@adityapatwardhan adityapatwardhan added Backport-7.2.x-Consider Backport-7.3.x-Consider CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Mar 14, 2023
@ghost
Copy link

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 13, 2023

🎉v7.2.11 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 13, 2023

🎉v7.3.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport-7.2.x-Done Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants