Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable HTTP persistence when using Session with Invoke-WebRequest and Invoke-RestMethod #19173

Closed
wants to merge 28 commits into from
Closed

Enable HTTP persistence when using Session with Invoke-WebRequest and Invoke-RestMethod #19173

wants to merge 28 commits into from

Commits on Feb 18, 2023

  1. Enable HTTP persistence when using Session

    @stevenebutler
    stevenebutler committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    a7f576e View commit details
    Browse the repository at this point in the history

  2. Address codefactor issues

    @stevenebutler
    stevenebutler committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    c5addae View commit details
    Browse the repository at this point in the history

  3. Merge branch 'PowerShell:master' into 12764-support-persistent-http-c… 

    …onnections-in-cmdlets
    @stevenebutler
    stevenebutler committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    ac534ef View commit details
    Browse the repository at this point in the history

  4. Address review comments by @CarloToso

    @stevenebutler
    stevenebutler committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    c722d2c View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2023

  1. Make -NoProxy and -Proxy switches flip each other's states 

    Addresses review comment by @CarloToso
    @stevenebutler
    stevenebutler committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    08e96a1 View commit details
    Browse the repository at this point in the history

  2. Address codefactor issues

    @stevenebutler
    stevenebutler committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    9dda627 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. Address @iSazanov review comments and suggestions 

    * Move GetHttpClient body to WebRequestSession
* Make internal properties setter only
* Implement IDisposable for WebRequestSession
* Add tests for persistence
* Fix GetHashCode() / Equals() on WebProxy
    @stevenebutler
    stevenebutler committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    7797a91 View commit details
    Browse the repository at this point in the history

  2. Address codefactor issues

    @stevenebutler
    stevenebutler committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    e104a79 View commit details
    Browse the repository at this point in the history

  3. Address more codefactor issues

    @stevenebutler
    stevenebutler committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    882be3c View commit details
    Browse the repository at this point in the history

  4. Tidy up comment

    @stevenebutler
    stevenebutler committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    f9e4e65 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'PowerShell:master' into 12764-support-persistent-http-c… 

    …onnections-in-cmdlets
    @stevenebutler
    stevenebutler committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    5f1c8d8 View commit details
    Browse the repository at this point in the history

  6. Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Web… 

    …Cmdlet/Common/WebRequestPSCmdlet.Common.cs

Co-authored-by: Ilya <darpa@yandex.ru>
    @stevenebutler @iSazonov
    stevenebutler and iSazonov committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    bdc1a2d View commit details
    Browse the repository at this point in the history

  7. Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Web… 

    …Cmdlet/Common/WebRequestPSCmdlet.Common.cs

Co-authored-by: Ilya <darpa@yandex.ru>
    @stevenebutler @iSazonov
    stevenebutler and iSazonov committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    49f2d8f View commit details
    Browse the repository at this point in the history

  8. Address review comments

    @stevenebutler
    stevenebutler committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    6b9578c View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary MaximumRedirection property

    @stevenebutler
    stevenebutler committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    f448308 View commit details
    Browse the repository at this point in the history

  10. Simplify logic around whether httpClient was disposed

    @stevenebutler
    stevenebutler committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    1c122b8 View commit details
    Browse the repository at this point in the history

  11. Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Web… 

    …Cmdlet/Common/WebRequestPSCmdlet.Common.cs

Co-authored-by: CarloToso <105941898+CarloToso@users.noreply.github.com>
    @stevenebutler @CarloToso
    stevenebutler and CarloToso committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    646aa79 View commit details
    Browse the repository at this point in the history

  12. Implements IDisposable to dispose WebSession 

    As per review request from @iSazonov, WebRequestPSCmdlet implements
IDisposable and cleans up non-persistent WebSession objects in the
Dispose method.
    @stevenebutler
    stevenebutler committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    1c7c0fd View commit details
    Browse the repository at this point in the history

  13. Move TimeoutSec handling to WebRequestSession 

    Responding to review comments from @iSazonov
    @stevenebutler
    stevenebutler committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    b69fe72 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2023

  1. Clean up variable naming in persistence test cases

    @stevenebutler
    stevenebutler committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    18eb46e View commit details
    Browse the repository at this point in the history

  2. Combine if expressions in dispose 

    As per review request by @iSazonov
    @stevenebutler
    stevenebutler committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    6bb5283 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Remove indentation

    @stevenebutler
    stevenebutler committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    7ae5471 View commit details
    Browse the repository at this point in the history

  2. Merge indentation change from master

    @stevenebutler
    stevenebutler committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    b7a5aff View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Ilya <darpa@yandex.ru>
    @stevenebutler @iSazonov
    stevenebutler and iSazonov committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    2aee3d8 View commit details
    Browse the repository at this point in the history

  2. Address review comments by @iSazonov 

    Comment improvements
Changed reconnection warning to verbose message
Moved verbose message text to resource
Updated tests
    @stevenebutler
    stevenebutler committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    d747ea2 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. codefactor fix

    @stevenebutler
    stevenebutler committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    237aaf7 View commit details
    Browse the repository at this point in the history

  2. Make parameter name clearer as per review suggestion

    @stevenebutler
    stevenebutler committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    14487d4 View commit details
    Browse the repository at this point in the history

  3. Rename function parameter to suppressHttpClientRedirects

    @stevenebutler
    stevenebutler committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    9f73991 View commit details
    Browse the repository at this point in the history