New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codefactor if part 5 #19286
Fix codefactor if part 5 #19286
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
@CarloToso Does the PR fix all rest issues? If so please activate analyzer rule. |
@iSazonov There are many more codefactor issues (more than 800) to fix before we can activate the analyzer rule. I think we should wait for dotnet format to work again (probably after the release of dotnet 8 stable) |
Maybe this work in Visual Studio? |
@iSazonov I think we can merge this. I currently can't test Visual Studio format, can you do it? |
🎉 Handy links: |
PR Summary
Fix codefactor errors with if
around 22 files
PR Context
Contributes to #19266
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).