Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures on Windows for time zone and remoting #19466

Merged
merged 7 commits into from
Apr 25, 2023

Conversation

adityapatwardhan
Copy link
Member

PR Summary

  • Fix test on Windows client where -SkipNetworkProfile check is needed.
  • Make Test-IsWinServer2012R2 a common help function and skip time zone tests correctly.

PR Context

PR Checklist

@ghost ghost added the Review - Needed The PR is being reviewed label Apr 15, 2023
@ghost
Copy link

ghost commented Apr 15, 2023

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan
Copy link
Member Author

@anmenaga - can you please review?

@ghost ghost removed the Review - Needed The PR is being reviewed label Apr 24, 2023
@adityapatwardhan adityapatwardhan merged commit cf6fc53 into PowerShell:master Apr 25, 2023
@adityapatwardhan adityapatwardhan deleted the FixWinTests branch April 25, 2023 18:06
@adityapatwardhan adityapatwardhan added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jun 28, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Test Indicates that a PR should be marked as a test change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants