-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ProductCode in registry for MSI install #19590
Add ProductCode in registry for MSI install #19590
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@adityapatwardhan Please take a look at failing tests. |
2e55c8e
to
a336c09
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
We should wait for at least 1 preview release before backporting this. |
🎉 Handy links: |
* Add ProductCode in registry for MSI install * Add test for validating ProductCode regkey is created * Add test better validation
* Add ProductCode in registry for MSI install * Add test for validating ProductCode regkey is created * Add test better validation
PR Summary
Add a registry key for the generated ProductCode using an MSI install. This is useful for doing an uninstallation by reading the reg key and avoids calling WMI for it.
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).