-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added -CaseInsensitive
switch parameter to Select-Object
& Get-Unique
cmdlets
#19683
Added -CaseInsensitive
switch parameter to Select-Object
& Get-Unique
cmdlets
#19683
Conversation
src/Microsoft.PowerShell.Commands.Utility/commands/utility/Select-Object.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetUnique.cs
Outdated
Show resolved
Hide resolved
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
@PowerShell/wg-powershell-cmdlets reviewed this, we agree that adding a |
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…nique` cmdlets (PowerShell#19683) * Added Select-Object CaseInsensitive parameter and tests * Added Get-Unique CaseInsensitive parameter and tests * Fix codefactor issue * Add named arguements * Remove comments
PR Summary
Fixes #12059
Added
-CaseInsensitive
switch parameter toSelect-Object
&Get-Unique
cmdlets.PR Context
The
Select-Object
andGet-Unique
cmdlets currently do case-sensitive string comparison when filtering unique items, and don't allow the user to override this behaviour and use case-insensitive comparison.To make sure no breaking change is introduced, the most ideal solution is to introduce a
-CaseInsensitive
parameter.Examples
Select-Object -Unique
Get-Unique
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.-CaseInsensitive
switch parameter toSelect-Object
&Get-Unique
cmdlet documentation MicrosoftDocs/PowerShell-Docs#10097(which runs in a different PS Host).