New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HostArchitecture dynamic for osxpkg #19917
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Mark |
PR Summary
As of PR #19450
New-UnixPackage()
takes a-HostArchitecture
param as it is needed to be passed toNew-FpmArguments
called in that method. Since-HostArchitecture
is passed as a param (even for osxpkg) we don't need to also create a dynamic param called-HostArchitecture
for osxpkg type package.PR Context
Will fix build issue.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).