New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed value from SecureString/PSCredential string conversion exception message #19977
Removed value from SecureString/PSCredential string conversion exception message #19977
Conversation
WG said about PSCredential too. |
@iSazonov Thanks for picking up on that. I've made some changes to also not expose the string in message when casting string to |
test/powershell/Modules/Microsoft.PowerShell.Security/SecureString.Tests.ps1
Outdated
Show resolved
Hide resolved
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution @ArmaanMcleod! ❤️
…nd `PSCredential` conversion failure (PowerShell#19977)
PR Summary
Fixes #19375
Removed value from exception message when
[securestring]
orConvertFrom-SecureString
fails to convert string to secure string.Also removed value when string is casted to PSCredential.
PR Context
Current behaviour
Below shows string to convert in exception message which should not be shown in-case it is sensitive data like tokens, passwords etc.
New behaviour
Removes string entirely from exception message.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).